[pve-devel] [pmg-devel] [PATCH-SERIES pve-common/pmg-api/pve-storage] pbs client: rework namespace usage and minor fixes

Fiona Ebner f.ebner at proxmox.com
Tue Oct 4 10:08:14 CEST 2022


Am 20.07.22 um 12:59 schrieb Fabian Ebner:
> Mostly done in preparation for #3186 (refactor pbs client use in PVE),
> to avoid the need to manually set the namespace for all call-sites in
> PVE, when it's already present in the storage/PBS config.
> 
> pve-common 1/5 and 2/5 and pmg-api 1/1 are improvements touching parts
> of the same infrastructure, but not directly related.
> 
> The other patches change PBSClient to auto-select the namespace from
> its initial configuration if not explicitly overriden with a
> namespaced parameter and deprecate namespaced parameters as a whole.
> 
> Rationale is that essentially all current users of PBSClient are
> configured for one namespace (there is the "status" call, which
> doesn't depend on a namespace, but that doesn't contradict the
> previous claim). It's less work on the call sites and there's no risk
> to forget namespacing a parameter (as happened with pxar_restore in
> PMG) if the PBSClient handles it itself.
> 
> If the need for handling more than one namespace with a single client
> ever arises, we can still add e.g. a set_namespace() function to the
> PBSClient.
> 
> Also makes it possible to restore a backup from a namespace in PMG,
> which currently fails.
> 
> 
> Dependency bump for new pve-common is needed for pve-storage and
> pmg-api.
> 
> 

Ping





More information about the pve-devel mailing list