[pve-devel] [PATCH-SERIES qemu(-server)/guest-common/manager/docs] make QEMU's max-workers setting configurable as a vzdump setting

Fiona Ebner f.ebner at proxmox.com
Mon Oct 3 15:52:03 CEST 2022


A few users reported IO-related issues during backup after upgrading
to PVE 7.x and using a modified QEMU build with max-workers reduced to
8 instead of 16 helped them [0].

Other BackupPerf settings are not exposed, see the qemu patch for why.

Introduces a more general 'performance' property string as a vzdump
setting to be expanded in the future. And in the long run, existing
performance settings like bwlimit could be moved into there.

To detect if the currently running QEMU supports the setting, the
query-proxmox-support QMP command is used. If not supported, a
warning is printed and the setting is ignored.

All but the last documentation patches are independent. The recently
created dedicated section for jobs is expanded and the introductory
section for backups is updated to mention PBS. The last patch mentions
the new performance/max-workers setting.

[0]: https://forum.proxmox.com/threads/113790/

Dependency bump manager -> guest-common is needed for the new
$PROPERTY_STRING hash.


qemu:

Fiona Ebner (1):
  PVE Backup: allow passing max-workers performance setting

 block/monitor/block-hmp-cmds.c |  4 +++-
 pve-backup.c                   | 18 +++++++++++++-----
 qapi/block-core.json           |  9 +++++++--
 3 files changed, 23 insertions(+), 8 deletions(-)


guest-common:

Fiona Ebner (1):
  vzdump: add 'performance' property string as a setting

 src/PVE/VZDump/Common.pm | 42 ++++++++++++++++++++++++++++++----------
 1 file changed, 32 insertions(+), 10 deletions(-)


qemu-server:

Fiona Ebner (1):
  vzdump: set max-workers QMP option when specified and supported

 PVE/VZDump/QemuServer.pm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)


manager:

Fiona Ebner (1):
  vzdump: handle new 'performance' property string

 PVE/API2/VZDump.pm        |  9 +++++----
 PVE/Jobs/VZDump.pm        | 23 ++++++++++-------------
 PVE/VZDump.pm             | 12 ++++++++++++
 configs/vzdump.conf       |  1 +
 www/manager6/dc/Backup.js |  8 +++++---
 5 files changed, 33 insertions(+), 20 deletions(-)


docs:

Fiona Ebner (4):
  backup: rework storage section, mentioning and recommending PBS
  backup: expand section for jobs
  backup: merge sections describing jobs
  backup: mention max-workers performance setting

 vzdump.adoc | 61 +++++++++++++++++++++++++++++++++++------------------
 1 file changed, 40 insertions(+), 21 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list