[pve-devel] [RFC v2 storage] Revert "Fix #2020: use /sys to map nvmeXnY to nvmeX"

[Stefan Hrdlicka]

Tried this change locally. Didn't break smart output for me :).

Tested-by: Stefan Hrdlicka <s.hrdlicka at proxmox.com>

On 11/28/22 12:29, Fiona Ebner wrote:
> This reverts commit c3442aa5546b029a524928d10c7ecabe0024c137.
> 
> Nowadays, relying on 'readlink /sys/block/nvmeXnY/device' won't always
> lead to the correct device, as reported in the community forum[0],
> where it results in '../../nvme-subsys0' and there's no matching entry
> under '/dev/'.
> 
> Since Linux kernel 5.4, in particular commit 733e4b69d508 ("nvme:
> Assign subsys instance from first ctrl"), the problematic situation
> from bug #2020 shouldn't happen anymore.
> 
> Stated more clearly by the commit's author here[1]:
>> Indeed, that commit will make the naming a bit more sane and will
>> definitely prevent mistaken identity. It is still possible to
>> observe controllers with instances that don't match their
>> namespaces, but it is impossible to get a namespace instance that
>> matches a non-owning controller.
> 
> The only other user of get_sysdir_info() doesn't use the 'device'
> entry, so reverting that part is fine too.
> 
> [0] https://forum.proxmox.com/threads/113962/
> [1] https://github.com/linux-nvme/nvme-cli/issues/510#issuecomment-552508647
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---