[pve-devel] [PATCH SERIES V4 pve-container/qemu-server/pve-manager 0/7] fix #3711 & adapt drive detach/remove behavior
Stefan Hrdlicka
s.hrdlicka at proxmox.com
Fri Nov 25 15:40:01 CET 2022
V3 -> V4:
# pve-container
* add check for linked clones to avoid partially deleting volumes
# pve-container
* remove ignore_storage_errors
* ignores now errors with PVE::Storage::path
# pve-manager
* remove checkbox ignore errors checkbox from VM delete
V2 -> V3:
# pve-storage
* change removed
# pve-container
* remove storage_exists
* reduce code lines used
# qemu-server
* reduce code lines used
# pve-manager
* no change
V1 -> V2:
# overall
* matched detaching/removing drives behavior for VM & containers
It currently works this way:
- Detach drive
- drive shows up as unused
- remove drive
- drive will be removed without removing data (obviously)
# pve-storage
* added storage_exists function for matching detach/remove behavoir
# pve-container
* review fixes:
* variable naming
* desciption string adapted
* moved eval further up the call chain
* removed ticket number form cleanup
* check if storage exists for unused disks
# qemu-server
* add same force option as for containers
* match detach/remove behavoir between VM/container
* shorten line
# pve-manager
* added same option for VMs as for containers
Stefan Hrdlicka (4):
fix #3711: optionally allow CT deletion to complete on disk volume
removal errors
adapt behavior for detaching/removing a mount point
add linked clone check for LXC container template deletion
cleanup: remove spaces from empty lines
src/PVE/API2/LXC.pm | 8 ++++++++
src/PVE/LXC.pm | 28 +++++++++++++++++++++-------
src/PVE/LXC/Config.pm | 6 +++++-
3 files changed, 34 insertions(+), 8 deletions(-)
--
2.30.2
More information about the pve-devel
mailing list