[pve-devel] [PATCH manager] ui: qemu disk: honor iothread setting from config

Dominik Csapak d.csapak at proxmox.com
Mon Nov 21 15:39:06 CET 2022


to have a iothread on by default in the wizard and on disk add, we
added a 'bind' for the value here. This also changes the value
for existing vm disks, and if one does not notice, modifies it
away again (since we don't have the controller here and isSCSISingle is
false)

simply don't bind value when we edit a vm disk from config

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/manager6/qemu/HDEdit.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js
index 921bfe72d..b78647ec8 100644
--- a/www/manager6/qemu/HDEdit.js
+++ b/www/manager6/qemu/HDEdit.js
@@ -255,10 +255,12 @@ Ext.define('PVE.qemu.HDInputPanel', {
 		name: 'iothread',
 		fieldLabel: 'IO thread',
 		clearOnDisable: true,
-		bind: {
+		bind: me.insideWizard || me.isCreate ? {
 		    disabled: '{!isVirtIO && !isSCSI}',
 		    // Checkbox.setValue handles Arrays in a different way, therefore cast to bool
 		    value: '{!!isVirtIO || (isSCSI && isSCSISingle)}',
+		} : {
+		    disabled: '{!isVirtIO && !isSCSI}',
 		},
 	    },
 	);
-- 
2.30.2






More information about the pve-devel mailing list