[pve-devel] [PATCH v2 http-server 0/2] fix #4344: ignore unused multipart headers

Matthias Heiserer m.heiserer at proxmox.com
Fri Nov 18 10:47:54 CET 2022


Reviewed-by: Matthias Heiserer <m.heiserer at proxmox.com>

On 18.11.2022 02:39, John Hollowell wrote:
> This fixes an issue where an upload request without a Content-Type in
> the file's multipart part would prevent the upload and throw
> missleading errors. This patch removes the requirement and ignores
> all multipart headers once the needed information has been extracted.
> 
> I have tested these changes against a 7.2-11 server and both a previously
> broken upload method (without the Content-Type) and using the webUI in
> Chrome (which includes a Content-Type) correctly uploads the file.
> 
> Changes since v1:
> * remove `xx` and escaping of spaces from regex
> 
> John Hollowell (2):
>    fix #4344: http-server: ignore unused multipart headers
>    Remove whitespace ignore from regex
> 
>   src/PVE/APIServer/AnyEvent.pm | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> --
> 2.30.2
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 






More information about the pve-devel mailing list