[pve-devel] applied: [PATCH manager v2 1/2] fix #3719: gui: expose LXC MTU option in web UI

[Thomas Lamprecht]

Am 11/11/2022 um 12:14 schrieb Stefan Hanreich:
> Some Notes:
> - Setting the MTU while the container is running, does not update the MTU of
>   the running container. If this is intended behavior it might be smart to
>   document it somewhere or throw a warning. This also doesn't
>   work for the VM patch. Not sure if this is even possible at runtime tbh.
> - Adding a network device when the Container is running with a specific,
>   valid MTU (e.g. 1234) does add the network device to the container, BUT it
>   has a MTU of 1500. Upon reboot the correct MTU is set. Reloading the
>   Network config does not change anything. Maybe just an LXC limitation?
> 

good notes which we should also improve (either implementing it or ensuring
that the change stays pending if it cannot be hot-plugged), but both
pre-existing behavior and so not a blocker for this.

> Code LGTM - small nit: there is still a gettext('MTU') left in the
> NetworkView, but it has been changed in the NetworkInputPanel.
> 
> Reviewed-by: Stefan Hanreich <s.hanreich at proxmox.com>
> Tested-by: Stefan Hanreich <s.hanreich at proxmox.com>

with above applied, thanks!