[pve-devel] applied-series: [PATCH qemu-server 0/6] Manage [special:cloudinit] in hotplug code

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 16 18:41:42 CET 2022


Am 16/11/2022 um 18:14 schrieb Wolfgang Bumiller:
> The inital series by Alexandre always dumped this section into the
> config even if no cloud-init was being used and the api to get the
> pending changes performed filtering which should instead be part of the
> hotplug code.
> 
> See the individual commit messages.
> 
> This partially reverts some of Thomas' cleanups as - unless I missed
> something - image generation and writing of the config only happens in
> paths that are already allowed to write it, plus, the hotplug code will
> now fully manage the [special:cloudinit] section, including removing
> values which have been reverted to the state that was used for the last
> cloud-init image generation.
> 
> Wolfgang Bumiller (6):
>   Revert "cloudinit: avoid unsafe write of VM config"
>   Partially-revert "cloudinit: add cloudinit section for current
>     generated config"
>   delay cloudinit generation in hotplug
>   record cloud-init changes in the cloudinit section
>   don't call 'cleanup_config' the cloudinit section
>   drop get_pending_changes and simplify cloudinit_pending api call
> 
>  PVE/API2/Qemu.pm            |  44 ++++++------
>  PVE/QemuServer.pm           | 132 +++++++++++++++++++++++++++++-------
>  PVE/QemuServer/Cloudinit.pm | 122 ++++++---------------------------
>  3 files changed, 153 insertions(+), 145 deletions(-)
> 


applied series, much thanks!





More information about the pve-devel mailing list