[pve-devel] [PATCH manager v10 08/13] ui: add form/Tag

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 16 15:57:41 CET 2022


For the subject: s!form/Tag!Proxmox.form.Tag component!

Am 15/11/2022 um 14:02 schrieb Dominik Csapak:
> +Ext.define('Proxmox.Tag', {

Would define it as 'Proxmox.form.Tag' matching the file hierarchy.


> +    extend: 'Ext.Component',
> +    alias: 'widget.pmxTag',

it's not wrong but it feels like there should be something more added to the
widget alias, but lacking a significantly better proposal tbh., pmxTagPicker
pmxTagDisplayEdit feel not really good either and it def. isn't a issue and
can stay as is too.







More information about the pve-devel mailing list