[pve-devel] [PATCH cluster/guest-common/qemu-server/container/wt/manager v10 0/5] add tags to ui
Dominik Csapak
d.csapak at proxmox.com
Tue Nov 15 14:02:25 CET 2022
this series brings the already existing 'tags' for ct/vms to the gui:
* tags can be edited in the status toolbar of the guest
* existing tags will be shown in the tree/global search/resource grids
* when editing a tag, a list of tags will be shown
* by default, the color is (consistently) autogenerated based on the
text
* that color can be overridden in datacenter -> options (cluster wide)
(edit window for browser local storage is TBD)
* by default, the text color is either white or black, depending which
provides the greater contrast (according to SAPC)
* this text color can also be overridden
* there are multiple shapes available for the tree
* implements some permission control in datacenter.cfg with
'user-tag-access' and 'privileged-tags' with that it's possible to have
better control over what tags a user can actually add to its guests
i intentionally left out the gui for those for now, but they shouldn't
be that hard to add, should we go this way
some notes:
* noticed that on firefox in linux, something is off with the
font-rendering, the text is weirdly aligned. not only with my tags,
but also in the regular buttons, etc. but with the editing of the
tags it's noticable. on a windows 10 machine i don't have the problem
with firefox (and chrome/chromium is ok also on linux)
* the privileged tags/user-tag-access editing is very basic, but imho
functional. if we want to have it 'fancier' please tell ;)
* maybe having the allowed tags in the 'ui-options' is not the
completely right place, but we only use it in the ui, and i did not
want to add another api call we have to call after logging in
(imho it's border-line already with)
changes from v9:
* implemented changes required by wolfgang
- fixed some c code behaviour
- refactored the permission check into guest-common
* changed a bit how the permission check worked:
- get_allowed_tags now takes a bool (privileged_user) and a closure
for checking the vm access. with this we can avoid a
cluster <-> access-control cyclic dependency
- refactored some of the internal code of the permission check
(see patch for details)
- the forbidden tags are now in quotes in the error
* added an optional 'ordering' option into the 'tag-style' property
with this the tags will be sorted in the gui (ui only)
i left the patches separately
changes from v8:
* renamed datacenter.cfg fields according to thomas input
* reworked the 'get_user_admin_tags' function to 'get_allowed_tags'
which now also checks the appropriate permissions and only returns
the allowed tags for the given user. (in list context also returns
the admin tags and if 'freeform' is allowed so that users can
check the privileges properly). this list is also added to the
'ui-options' api call, since we'll use it for showing tag suggestions
* included the missing css styles in the appropriate patches
* changed the styling of tags while editings (emulate a textfield) to
make it clearer it's ready for editing
* changed the color of the 'add tag' field
* added a gui for editing the privileged tags and the user-tag-access
field
* imroved wording + description
* improved commit messages
* changed how we collect the taglist for the tag picker
* mention the tags in the privilige check
* added the allowed tags to the ui-options
(omitted older changelog)
pve-cluster:
Dominik Csapak (5):
add CFS_IPC_GET_GUEST_CONFIG_PROPERTIES method
Cluster: add get_guest_config_properties
datacenter.cfg: add option for tag-style
datacenter.cfg: add tag rights control to the datacenter config
datacenter.cfg: add 'ordering' to 'tag-style' config
data/PVE/Cluster.pm | 27 +++++
data/PVE/DataCenterConfig.pm | 149 ++++++++++++++++++++++++++++
data/src/cfs-ipc-ops.h | 2 +
data/src/server.c | 63 ++++++++++++
data/src/status.c | 184 ++++++++++++++++++++++++-----------
data/src/status.h | 3 +
6 files changed, 370 insertions(+), 58 deletions(-)
pve-guest-common:
Dominik Csapak (1):
GuestHelpers: add 'assert_tag_permissions'
debian/control | 3 ++-
src/PVE/GuestHelpers.pm | 54 ++++++++++++++++++++++++++++++++++++++++-
2 files changed, 55 insertions(+), 2 deletions(-)
qemu-server:
Dominik Csapak (1):
api: update: check for tags permissions with 'assert_tag_permissions'
PVE/API2/Qemu.pm | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
pve-container:
Dominik Csapak (1):
check_ct_modify_config_perm: check for tags permissions with
'assert_tag_permissions'
src/PVE/LXC.pm | 4 ++++
1 file changed, 4 insertions(+)
proxmox-widget-toolkit:
Dominik Csapak (2):
add tag related helpers
Toolkit: add override for Ext.dd.DragDropManager
src/Toolkit.js | 16 ++++++++
src/Utils.js | 88 ++++++++++++++++++++++++++++++++++++++++++++
src/css/ext6-pmx.css | 52 ++++++++++++++++++++++++++
3 files changed, 156 insertions(+)
pve-manager:
Dominik Csapak (13):
api: /cluster/resources: add tags to returned properties
api: add /ui-options api call
ui: call '/ui-options' and save the result in PVE.UIOptions
ui: parse and save tag infos from /ui-options
ui: add form/TagColorGrid
ui: add PVE.form.ListField
ui: dc/OptionView: add editors for tag settings
ui: add form/Tag
ui: add form/TagEdit.js
ui: {lxc,qemu}/Config: show Tags and make them editable
ui: tree/ResourceTree: show Tags in tree
ui: add tags to ResourceGrid and GlobalSearchField
ui: implement tag ordering from datacenter.cfg
PVE/API2.pm | 61 +++++
PVE/API2/Cluster.pm | 9 +-
www/css/ext6-pve.css | 57 ++++
www/manager6/Makefile | 4 +
www/manager6/Utils.js | 95 ++++++-
www/manager6/Workspace.js | 2 +
www/manager6/data/ResourceStore.js | 7 +
www/manager6/dc/OptionView.js | 221 ++++++++++++++-
www/manager6/form/GlobalSearchField.js | 20 +-
www/manager6/form/ListField.js | 165 ++++++++++++
www/manager6/form/Tag.js | 232 ++++++++++++++++
www/manager6/form/TagColorGrid.js | 357 +++++++++++++++++++++++++
www/manager6/form/TagEdit.js | 336 +++++++++++++++++++++++
www/manager6/grid/ResourceGrid.js | 1 +
www/manager6/lxc/Config.js | 36 ++-
www/manager6/qemu/Config.js | 35 ++-
www/manager6/tree/ResourceTree.js | 10 +-
17 files changed, 1630 insertions(+), 18 deletions(-)
create mode 100644 www/manager6/form/ListField.js
create mode 100644 www/manager6/form/Tag.js
create mode 100644 www/manager6/form/TagColorGrid.js
create mode 100644 www/manager6/form/TagEdit.js
--
2.30.2
More information about the pve-devel
mailing list