[pve-devel] applied: [pbs-devel] [PATCH proxmox-backup v4 1/1] file-restore: make dynamic memory behaviour controllable
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Nov 15 09:29:02 CET 2022
Am 10/11/2022 um 11:36 schrieb Dominik Csapak:
> by adding 'dynamic-memory' parameter that controls if we automatically
> increase the memory of the guest vm or not
>
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> new in v4
>
> not really happy with the 'clippy allow', but imho there is no obvious way to
> bundle those parameters without restructuring the code much
>
> proxmox-file-restore/src/block_driver.rs | 10 +++-
> proxmox-file-restore/src/block_driver_qemu.rs | 6 ++-
> proxmox-file-restore/src/main.rs | 54 +++++++++++++++++--
> 3 files changed, 61 insertions(+), 9 deletions(-)
>
>
applied, but superseeded looping thorugh a new param over quite a few function by
getting this out from the PBS_FILE_RESTORE_MEM_HOTPLUG_ALLOW environment variable
being set to "true", thanks!
Note that I also made a few other followups to that code, e.g., introducing QMPSock
to avoid having QMP internals in a rather unrelated function, among other things.
More information about the pve-devel
mailing list