[pve-devel] applied: [PATCH docs v3 1/2] asciidoc-pve: disallow certain characters in onlineHelp keys

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 14 19:50:41 CET 2022


Am 14/11/2022 um 12:38 schrieb Stefan Sterz:
> this removes the lazily evaluated part of the regex used to detect
> `onlineHelp` keys in order to match them with asciidoc anchors in the
> documentation. it uses a pattern that excludes curly braces, brackets
> and quotations instead. this allows for greedy matching and also
> removes an issue where keys that are set via CBind were included
> incorrectly. the script would try to find an anchor name that was
> equivalent to the CBind placeholder, which would fail.
> 
> since brackets, curly braces and quotation marks aren't allowed in
> asciidoc anchors anyway, excluding them like this should be safe.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
>  asciidoc-pve.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list