[pve-devel] [PATCH manager v3 0/2] pve fix help buttons by accounting for keys in widget toolkit

Stefan Sterz s.sterz at proxmox.com
Mon Nov 14 12:38:26 CET 2022


this patch series fixes an issue where `onlineHelp` keys, that were
only used by components in the widget toolkit, were not properly
mapped to the corresponding anchors in the docs. this lead to
affected help buttons only showing an error message.

this series first fixes `pve-docs` by making `asciidoc-pve`
a bit less aggressiv in order to avoid keys that are set by cbind.
then it adds the toolkit as a build dependency to `pve-manager` and
scans the toolkit for keys there when building the front-end.


changes from v2, thanks @ Thomas Lamprecht:

* rebase to current master
* move to greedy regex

changes from v1, thanks @ Thomas Lamprecht:

* scan the widget toolkit too and not just components in
  `pve-manager`

Stefan Sterz (1):
  asciidoc-pve: disallow certain characters in onlineHelp keys

 asciidoc-pve.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Stefan Sterz (1):
  fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js

 debian/control        | 1 +
 www/manager6/Makefile | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list