[pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

Stefan Sterz s.sterz at proxmox.com
Mon Nov 14 11:13:00 CET 2022


On 11/14/22 11:07, Thomas Lamprecht wrote:
> Am 14/11/2022 um 09:26 schrieb Stefan Sterz:
>>> IIUC this indirectly raised the minimum length of references to two characters,
>>> not a deal breaker IMO as I don't really expect two characters to be used anytime
>>> soon (maybe with unicode 🤔🧠💭 x)), but maybe hint it in the commit message.
>>>
>> yes that is correct. just to have made the suggestion: the "[^}]" could
>> be dropped here. that should get us back down to one character, but will
>> also filter the necessary keys. and anchors like "{key" are just as
>> invalid as "{key}" in asciidoc.
>>
> 
> 
> or move it to a single one replacing the whole non-greedy part, something like
> (untested): [^{}\[\]"']+
> 
should work to, yes. i used grep to test this and it worked (i did need
to do some escaping for the quotes, but the idea seems solid). i'll send
a v3 with this if you approve :)






More information about the pve-devel mailing list