[pve-devel] applied-series: [PATCH docs 00/10] docs (mostly) spelling update

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 9 15:51:10 CET 2022


Am 09/11/2022 um 12:58 schrieb Matthias Heiserer:
> These are mostly about the first chapters, I'll try to look through the later ones aswell.
> Many small patches, feel free to squash them, but I figured it's easier that way when the inevitable
> discussions about proper spelling arise :)
> 
> 
> Matthias Heiserer (10):
>   consistently use 'web interface' (two words)
>   remove misplaced comma
>   consistently capitalize Ceph
>   add note that secure boot needs to be disabled for host installation
>   UPDATE IMAGE IN DOCSgit diff pve-installation.adocgit diff
>     pve-installation.adoc! Installation options were moved into advanced
>     folder, update docs to reflect that.
>   add missing comma in if sentences
>   rephrase when root password is set to make it clear that when logging
>     it, it is already set
>   add missing letter
>   it's -> its because it isn't 'it is'
>   update link to debian handbook. current one is 404
> 
>  certificate-management.adoc         |  2 +-
>  hyper-converged-infrastructure.adoc |  6 +++---
>  pve-installation.adoc               | 18 +++++++++---------
>  pve-storage-pbs.adoc                |  2 +-
>  pve-storage-rbd.adoc                |  4 ++--
>  pveceph.adoc                        |  6 +++---
>  sysadmin.adoc                       |  4 ++--
>  7 files changed, 21 insertions(+), 21 deletions(-)
> 


applied series, thanks!

Note that I squashed two patches and reworded a few commit messages
slightly. Most of how you separated the series was pretty good (e.g., some
tree wide change for consistent Ceph spelling makes sense in one patch) but
I think in general you might want to have simple, obvious typo fixes (i.e.,
no big rewordings) from the same chapter squashed into a single patch and
prefix the commit subject with the chapter/topic (like "installation:" or
"ceph:") but at least squashing is really quickly done from my side (and
always simpler than splitting up again), so I didn't mind about how you did
the separation, just noting that I don't expected/want every single specific
typo in its own patch.





More information about the pve-devel mailing list