[pve-devel] [PATCH manager v1 1/2] fix #4328: make help buttons in the markdown editor window work again

[Thomas Lamprecht]

Am 08/11/2022 um 16:01 schrieb Stefan Sterz:
> when the `onlineHelp` of a component is defined in the widget toolkit
> `asciidoc-pve` can't pick up on that and `OnlineHelpInfo.js` won't
> contain the necessary keys. this patch sets `onlineHelp` in this
> package again to avoid that.
> 
> note: technically it would be enough to set this for one of the three
> usages of `pmxNotesView`, as then `asciidoc-pve` would add it to
> `OnlineHelpInfo.js` again. however, for consistency's sake i added it
> to all occurrences.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> so this issue doesn't only affect the markdown notes, there are also
> other components affected by this. afict this includes:
> 
> * `proxmoxNodeNetworkView`: needs `sysadmin_network_configuration`,
>   which works because it is also set in `node/Config.js`, similar to
>   this fix.
> * several components related to tfa need `user_mgmt` which are all
>   currently broken, because that key isn't used at all in
>   `pve-manager`.
> 
> i think it would be nice to have a solution that allows setting such
> keys in the widget toolkit only, but that would require one of two
> changes:
> 
> 1. always add all possible keys to `OnlineHelpInfo.js`. to my
>    understanding, this is similar to how pbs currently creates its
>    `OnlineHelpInfo.js`
> 2. include the widget toolkit's javascript files in the input to
>    `asciidoc-pve`. however, i am unsure how we could do so elegantly.

 please go for 2., I'd do so by adding proxmox-widget-toolkit to the
 Build-Depends list in d/control and parse it from the file at
 /usr/share/javascript/proxmox-widget-toolkit/proxmoxlib.js