[pve-devel] applied: [RFC common 1/1] change cpu shares: drop unused $cgroupv1_default parameter

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 7 16:30:03 CET 2022


Am 07/10/2022 um 14:41 schrieb Fiona Ebner:
> The only expression it appears in short-circuits, because the line
> before ensures that $shares is guaranteed to be set.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> Before we can add a new parameter to the function again, it would need
> a Breaks for qemu-server and pve-container. So maybe we prefer to just
> leave it as is? cgroupv1 won't be around forever anyways.
> 
>  src/PVE/CGroup.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, with a note added to the method to record the hint about breakage if
we add new params to it, at least during this major release series, thanks!





More information about the pve-devel mailing list