[pve-devel] [PATCH manager] gui: fix firewall security group help button chapter link

Daniel Tschlatscher d.tschlatscher at proxmox.com
Fri Nov 4 10:18:47 CET 2022


The help button under Datacenter > Firewall > Security Group did not
have the proper help chapter link set.

First reported here:
https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/

Signed-off-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>
---
I noticed that the onlineHelp field for our custom classes is
sometimes defined outside of the class, in the Config which defines
the layout of the navigation panel, and sometimes inside of the class
directly.
This time I added it inside the class, as it seems to be the more
commonly used thing. Though, is there any preference for this?


 www/manager6/dc/SecurityGroups.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/dc/SecurityGroups.js b/www/manager6/dc/SecurityGroups.js
index 5fb6860d..26172bf3 100644
--- a/www/manager6/dc/SecurityGroups.js
+++ b/www/manager6/dc/SecurityGroups.js
@@ -199,6 +199,7 @@ Ext.define('PVE.SecurityGroups', {
     alias: 'widget.pveSecurityGroups',
 
     title: 'Security Groups',
+    onlineHelp: 'pve_firewall_security_groups',
 
     layout: 'border',
 
-- 
2.30.2






More information about the pve-devel mailing list