[pve-devel] [PATCH-SERIES v2 storage/manager/guest-common/docs] improvements for protected backups

[Fabian Ebner]

The series consists of two parts:

First part (up to docs 2/2) is for introducing a storage property
to limit the number of protected backups and only count unprotected
backups for the limit check in vzdump. This is useful to still be able
to limit the amount of backups a user can make, because protected
backups are not considered when pruning, and a user with backup
privilege could mark their new backups as protected each time.

Second part introduces 'protected' and a 'notes-template' option to
generate notes from a template string with certain variables for
vzdump, and adds them for manual backup and backup jobs in the UI.


Changes from v1:
    * Add some rationale to the cover letter.
    * Drop already applied patch.
    * Default to unlimited for privileged users. I also dropped the
      patch to dynamically set the property upon storage creation in
      the UI, because the default itself is more dynamic now.
    * Switch to a template string for notes, supporting certain
      variables.


Previous discussion here:
https://lists.proxmox.com/pipermail/pve-devel/2021-December/051214.html


storage:

Fabian Ebner (1):
  plugins: allow limiting the number of protected backups per guest

 PVE/Storage.pm                 | 35 ++++++++++++++++++++++++++++++++++
 PVE/Storage/BTRFSPlugin.pm     |  3 ++-
 PVE/Storage/CIFSPlugin.pm      |  1 +
 PVE/Storage/CephFSPlugin.pm    |  1 +
 PVE/Storage/DirPlugin.pm       |  1 +
 PVE/Storage/GlusterfsPlugin.pm |  1 +
 PVE/Storage/NFSPlugin.pm       |  1 +
 PVE/Storage/PBSPlugin.pm       |  1 +
 PVE/Storage/Plugin.pm          |  7 +++++++
 9 files changed, 50 insertions(+), 1 deletion(-)


manager:

Fabian Ebner (8):
  vzdump: backup file list: drop unused parameter
  vzdump: backup limit: only count unprotected backups
  ui: storage edit: retention: add max-protected-backups setting
  vzdump: support setting protected status
  partially close #438: vzdump: support setting notes-template
  ui: backup: allow setting protected and notes-template for manual
    backup
  close #438: ui: backup job: allow setting a notes-template for a job
  ui: backup job: set guest name as default notes-template

 PVE/VZDump.pm                        | 89 +++++++++++++++++++++-------
 www/manager6/dc/Backup.js            | 18 ++++++
 www/manager6/panel/BackupJobPrune.js | 47 ++++++++++++---
 www/manager6/storage/Base.js         |  1 +
 www/manager6/window/Backup.js        | 25 +++++++-
 5 files changed, 147 insertions(+), 33 deletions(-)


docs:

Fabian Ebner (2):
  storage: switch to prune-backups in examples
  vzdump/storage: mention protected backups limit and give an example

 pve-storage-dir.adoc | 9 +++++----
 pve-storage-pbs.adoc | 2 +-
 vzdump.adoc          | 5 +++++
 3 files changed, 11 insertions(+), 5 deletions(-)


guest-common:

Fabian Ebner (1):
  vzdump: schema: add 'notes-template' and 'protected' properties

 src/PVE/VZDump/Common.pm | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

-- 
2.30.2