[pve-devel] [PATCH v4 manager 6/6] ui: util: refactor mps to mp

Aaron Lauterer a.lauterer at proxmox.com
Thu Mar 24 11:44:48 CET 2022



On 3/22/22 12:18, Fabian Ebner wrote:
> Am 14.03.22 um 10:35 schrieb Aaron Lauterer:
>> @@ -1805,9 +1805,7 @@ Ext.define('PVE.Utils', {
>>       },
>>   
>>       nextFreeMP: function(type, config) {
>> -	let mptype = type === "mp" ? "mps" : type;
>> -
>> -	for (let i = 0; i < PVE.Utils.mp_counts[mptype]; i++) {
>> +	for (let i = 0; i < PVE.Utils.mp_counts[type]; i++) {
>>   	    let confid = `${type}${i}`;
>>   	    if (!Ext.isDefined(config[confid])) {
>>   		return {
> 
> Nit: If this patch were ordered before the first one, we could start out
> with the simpler version.

True but I went with the approach to make this change optional. That's why it is the last in the series.





More information about the pve-devel mailing list