[pve-devel] [PATCH manager 5/5 v2] Storage ContentView: Remove dead code
Fabian Ebner
f.ebner at proxmox.com
Tue Mar 22 09:48:50 CET 2022
Am 18.03.22 um 14:52 schrieb Matthias Heiserer:
> These lines were only used by grid/BackupView, which gets deleted in
> this series.
>
>
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
> www/manager6/storage/ContentView.js | 22 ++--------------------
> 1 file changed, 2 insertions(+), 20 deletions(-)
>
> diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
> index 2874b71e..cb22ab4d 100644
> --- a/www/manager6/storage/ContentView.js
> +++ b/www/manager6/storage/ContentView.js
> @@ -155,20 +155,6 @@ Ext.define('PVE.storage.ContentView', {
> renderer: PVE.Utils.render_storage_content,
> dataIndex: 'text',
> },
> - 'notes': {
> - header: gettext('Notes'),
> - flex: 1,
> - renderer: Ext.htmlEncode,
> - dataIndex: 'notes',
> - },
> - 'protected': {
> - header: `<i class="fa fa-shield"></i>`,
> - tooltip: gettext('Protected'),
> - width: 30,
> - renderer: v => v ? `<i data-qtip="${gettext('Protected')}" class="fa fa-shield"></i>` : '',
> - sorter: (a, b) => (b.data.protected || 0) - (a.data.protected || 0),
> - dataIndex: 'protected',
> - },
> 'date': {
> header: gettext('Date'),
> width: 150,
> @@ -194,10 +180,6 @@ Ext.define('PVE.storage.ContentView', {
> delete availableColumns[key];
> }
>From a quick look, the showColumns special casing right above here seems
to also be unnecessary now.
> });
> -
> - if (me.extraColumns && typeof me.extraColumns === 'object') {
> - Object.assign(availableColumns, me.extraColumns);
> - }
> const columns = Object.values(availableColumns);
>
> Ext.apply(me, {
> @@ -216,8 +198,8 @@ Ext.define('PVE.storage.ContentView', {
> Ext.define('pve-storage-content', {
> extend: 'Ext.data.Model',
> fields: [
> - 'volid', 'content', 'format', 'size', 'used', 'vmid',
> - 'channel', 'id', 'lun', 'notes', 'verification',
> + 'volid', 'content', 'format', 'size', 'used',
> + 'channel', 'id', 'lun',
> {
> name: 'text',
> convert: function(value, record) {
More information about the pve-devel
mailing list