[pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView.

Fabian Ebner f.ebner at proxmox.com
Tue Mar 22 09:47:39 CET 2022


There's certain things that need to be changed to not break existing
work flows:

* Restoring doesn't overwrite the existing guest anymore and can't be
used for that anymore.
* Should not only filter by ID, but by type + ID.
* Cannot get rid of the ID filtering anymore. Currently, it always
filters by type, so we might want to keep that behavior.

Nit: introducing the guest-view specific functionality to the BackupView
class could've been part of this patch (or its own preparatory one), but
not sure if it's worth the effort (anymore).

Am 18.03.22 um 14:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---
>  www/manager6/lxc/Config.js  | 2 +-
>  www/manager6/qemu/Config.js | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js
> index 89b59c9b..242780c8 100644
> --- a/www/manager6/lxc/Config.js
> +++ b/www/manager6/lxc/Config.js
> @@ -256,7 +256,7 @@ Ext.define('PVE.lxc.Config', {
>  	    me.items.push({
>  		title: gettext('Backup'),
>  		iconCls: 'fa fa-floppy-o',
> -		xtype: 'pveBackupView',
> +		xtype: 'pveStorageBackupView',
>  		itemId: 'backup',
>  	    },
>  	    {
> diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js
> index 9fe933df..3ed2427a 100644
> --- a/www/manager6/qemu/Config.js
> +++ b/www/manager6/qemu/Config.js
> @@ -291,7 +291,7 @@ Ext.define('PVE.qemu.Config', {
>  	    me.items.push({
>  		title: gettext('Backup'),
>  		iconCls: 'fa fa-floppy-o',
> -		xtype: 'pveBackupView',
> +		xtype: 'pveStorageBackupView',
>  		itemId: 'backup',
>  	    },
>  	    {





More information about the pve-devel mailing list