[pve-devel] [PATCH manager 1/2] ui: disk storage selector: never send format when hideFormat is true

Fabian Ebner f.ebner at proxmox.com
Thu Mar 17 09:37:47 CET 2022


The backend will pick an appropriate format when nothing is specified. The
comment made it sound like 'raw' would be sent, but that didn't actually happen
on file-based storages, and now no format is sent, so adapt the comment too.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 www/manager6/form/DiskStorageSelector.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
index ac6b064f..14a678b7 100644
--- a/www/manager6/form/DiskStorageSelector.js
+++ b/www/manager6/form/DiskStorageSelector.js
@@ -28,7 +28,7 @@ Ext.define('PVE.form.DiskStorageSelector', {
     // hides the size field (e.g, for the efi disk dialog)
     hideSize: false,
 
-    // hides the format field (e.g. for TPM state), always assumes 'raw'
+    // hides the format field (e.g. for TPM state)
     hideFormat: false,
 
     // sets the initial size value
@@ -66,7 +66,7 @@ Ext.define('PVE.form.DiskStorageSelector', {
 
 	var select = !!rec.data.select_existing && !me.hideSelection;
 
-	formatsel.setDisabled(!selectformat);
+	formatsel.setDisabled(!selectformat || me.hideFormat);
 	formatsel.setValue(selectformat ? 'qcow2' : 'raw');
 
 	hdfilesel.setDisabled(!select);
-- 
2.30.2






More information about the pve-devel mailing list