[pve-devel] applied: [PATCH-SERIES v3 storage/manager] factoring out RE for backup extension

[Dominik Csapak]

On 3/16/22 17:16, Thomas Lamprecht wrote:
> On 04.11.21 15:40, Dominik Csapak wrote:
>> Series LGTM, looked closely at the regexes,
>> and they match (semantically), tested around a bit
>> and all seemed to work.
>>
>> one super small nit (not a blocker IMHO)
>>
>> the format/extension/compression handling in 2/2
>> could maybe use a comment what we do there
>> (though maybe it's just me who's confused ^^)
>>
> 
> can you send a follow up with what you have in mind?
> 

honestly i cannot totally remember what i meant, but i guess the line

(my $format = $extension) =~ s/\..*//;

confused me at first, but in now it's obvious to me that we strip the
compression from the extension...

should i send a patch to comment that ?