[pve-devel] [PATCH manager 1/3] GUI: Allow passing the node to BackupConfig directly.

Fabian Ebner f.ebner at proxmox.com
Wed Mar 9 13:28:24 CET 2022


Am 04.03.22 um 12:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
> ---

Some rationale for the change would be nice to have in the commit
message. Is there a scenario where me.pveSelNode is not the correct node?

>  www/manager6/window/BackupConfig.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/window/BackupConfig.js b/www/manager6/window/BackupConfig.js
> index ca61b1e4..9609fe34 100644
> --- a/www/manager6/window/BackupConfig.js
> +++ b/www/manager6/window/BackupConfig.js
> @@ -24,7 +24,7 @@ Ext.define('PVE.window.BackupConfig', {
>  	    throw "no volume specified";
>  	}
>  
> -	var nodename = me.pveSelNode.data.node;
> +	var nodename = me.node ?? me.pveSelNode.data.node;
>  	if (!nodename) {
>  	    throw "no node name specified";
>  	}





More information about the pve-devel mailing list