[pve-devel] applied-series: Re: [PATCH pve-kernel-meta/proxmox-ve v3] proxmox-boot: add kernel pinning functionality (#3761)

[Thomas Lamprecht]

On 11/02/2022 16:15, Stoiko Ivanov wrote:
> pve-kernel-meta:
> Stoiko Ivanov (4):
>   proxmox-boot: return empty if file does not exist in get_first_line
>   proxmox-boot: fix #3671 add pin/unpin for kernel-version
>   proxmox-boot: add --next-boot option kernel pin command
>   proxmox-boot: add pin/unpin functionality for non-p-b-t systems
> 
>  bin/proxmox-boot-tool                     | 97 +++++++++++++++++++++++
>  debian/pve-kernel-helper.install          |  1 +
>  debian/rules                              |  3 +
>  proxmox-boot/Makefile                     |  4 +
>  proxmox-boot/functions                    | 45 +++++++++++
>  proxmox-boot/proxmox-boot-cleanup.service | 13 +++
>  proxmox-boot/zz-proxmox-boot              |  8 ++
>  7 files changed, 171 insertions(+)
>  create mode 100644 proxmox-boot/proxmox-boot-cleanup.service
> 
> proxmox-ve:
> Stoiko Ivanov (3):
>   apt-hook: fix perlcritic warnings
>   apt-hook: verify that fd is numeric
>   apt-hook: add check preventing the removal of pinned kernels
> 
>  debian/apthook/pve-apt-hook | 36 +++++++++++++++++++++++++++++++++---
>  1 file changed, 33 insertions(+), 3 deletions(-)
> 

applied, thanks!

amended the bug number in patch 2/4 (thx Oguz) and made some small followups
(i had those lying around since a while and only committed now, I think
I had some other small things in mind when revieiwing this originally, but
nothing critical at all), mostly outputting possible pve kversions options
to choose from in some error cases and outputting when a previous pin gets
overridden with new one.

We could add a proxmox-ve
Breaks: pve-kernel-helper (<< 7.1-13)

to ensure this always works cleanly (not that a pinnend kernel gets removed)
but the case when this can happen is very odd and people should really not
hold back upgrading proxmox-ve, makes not much sense to do.