[pve-devel] applied: [PATCH guest-common] GuestHelpers: fix snapshot indentation length

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 1 13:13:48 CET 2022


On 28.02.22 15:46, Dominik Csapak wrote:
> if a user has many snapshots, the length goes negative and produces
> wrong indentation, so clamp it at 0
> 
> reported by a user in the forum:
> https://forum.proxmox.com/threads/non-threaded-listsnaphost-view.105740/
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> for many snapshots this still looks weird, but has a consistent indentation.
> to do it completely right, we'd have to iterate twice and find the
> longest line first and use that as width for the first column. not
> sure if worth the effort.

yeah I think that for now it's OK to not (La)Tex level features here, albeit
it'd not be *that* hard. FWIW, I reduced the space indentation per level from
two to one, looks better that way and allows for more snapshots to be displayed
correctly before clamping kicks in.

> 
>  src/PVE/GuestHelpers.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!





More information about the pve-devel mailing list