[pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall

[Alexandre Derumier]

Hi,

I was doing some profiling of qm && pct command,
and I have found around 100ms cpu time just for the
use of PVE::Firewall in qemu-server && pve-container
for 2 small helpers. (clone_vmfw_conf && remove_vmfw_conf)

as PVE::Firewall require QemuServer && LXC,
we are loading full lxc in qm too.

Also, LXC have some include of PVE::Firewall
in different packages, not used,
but it was magically including QemuServer,
which including the json schema "pve-targetstorage",
used by lxc too.

I have moved this schema to main jsonschema in pve-common


Alexandre Derumier (1):
  schema: add pve-targetstorage (moved from qemu-server)

 src/PVE/JSONSchema.pm | 7 +++++++
 1 file changed, 7 insertions(+)

-- 

Alexandre Derumier (1):
  move clone_vmfw_conf && remove_vmfw_conf to a Helpers

 src/PVE/Firewall.pm         | 25 ----------------------
 src/PVE/Firewall/Helpers.pm | 41 +++++++++++++++++++++++++++++++++++++
 src/PVE/Firewall/Makefile   | 12 +++++++++++
 src/PVE/Makefile            |  2 ++
 4 files changed, 55 insertions(+), 25 deletions(-)
 create mode 100644 src/PVE/Firewall/Helpers.pm
 create mode 100644 src/PVE/Firewall/Makefile

-- 

Alexandre Derumier (2):
  api2: use firewall helpers
  qemu-server: remove json schema pve-targetstorage (moved to
    pve-common)

 PVE/API2/Qemu.pm  | 8 ++++----
 PVE/QemuServer.pm | 7 -------
 2 files changed, 4 insertions(+), 11 deletions(-)

-- 

Alexandre Derumier (2):
  remove unused use PVE::Firewall
  api2 : use firewall helpers

 src/PVE/API2/LXC.pm          | 10 +++++-----
 src/PVE/API2/LXC/Config.pm   |  1 -
 src/PVE/API2/LXC/Snapshot.pm |  1 -
 src/PVE/API2/LXC/Status.pm   |  1 -
 4 files changed, 5 insertions(+), 8 deletions(-)

-- 
2.30.2