[pve-devel] [PATCH V2 manager 2/3] cleanup: "var" to "let", fix some indentation in related files

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jun 28 15:10:33 CEST 2022


On 28/06/2022 12:54, Fabian Ebner wrote:
> Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
>> replace all "var" with "let" in files related to patch for ticket 2822
>>
>> Signed-off-by: Stefan Hrdlicka <s.hrdlicka at proxmox.com>
> 
> While this patch can be fine, I think the next one is a bit too big ;)
> It might introduce subtle bugs (since we might be relying on the
> semantics of var somewhere) and I'd rather continue having the
> conversion be done organically for a while, with patches limited in
> scope (pun intended) like this one being okay.
> 
> @Dominik, @Thomas opinions?

+1

Such general and (semi-)automatable cleanups are IMO better applied by
maintainers directly, they can push out a quick fix if anything is off
and often are much more experienced in the code base to have a feeling
where it actually has a benefit (parts seeing more churn) and how safe
it is wrt. to side effects.




More information about the pve-devel mailing list