[pve-devel] [PATCH common/cluster/qemu/container/wt/manager v7] add tags to ui

Dominik Csapak d.csapak at proxmox.com
Tue Jun 21 11:19:48 CEST 2022


this series brings the already existing 'tags' for ct/vms to the gui:
* tags can be edited in the status toolbar of the guest
* existing tags will be shown in the tree/global search/resource grids
* when editing a tag, a list of existing tags will be shown
* by default, the color is (consistently) autogenerated based on the
  text
* that color can be overriden in datacenter -> options (cluster wide)
  (edit window for browser local storage is TBD)
* by default, the text color is either white or black, depending which
  provides the greater contrast (according to SAPC)
* this text color can also be overridden
* there are multiple shapes available for the tree (see [0])
* adds new 'admin' tags that need higher privliges, these can then be
  used to enable features like 'inlude in backup by tag', etc.

i left the patches of the 'admin' tags seperate, so that we can
decide if this is the right approach, but still apply some other parts.
(pve-common 2/2, wt 2/3, qemu-server, pve-container, pve-manager 12/14)

same with the gui patches for drag&drop, not sure if the ux is good
enough.
(wt 3/3, pve-manager: 14/14)

sorry for the large series....

(i omitted the changeslogs up to v6, were getting a bit long ;) )

changes from v6:
* reworded some commit messages
* added small benchmark result to CFS_IPC_GET_GUEST_CONFIG_PROPERTIES commit msg
* reshaped datacenter.cfg format into a property-string
  (also combined the gui edit window for shape+color override)
* refactored the pve-tags regex in pve-common/JSONSchema
* added admin tags ('+tag' syntax) with priv checks in qemu-sever/pve-container
  and subtle highlighting in the gui (bold-text)
* added tag rendering in resource grids
* add patches for drag&drop support when editing

pve-common:

Dominik Csapak (2):
  JSONSchema: refactor tag regex
  JSONSchema: pve-tag: add syntax for 'admin' tags

 src/PVE/JSONSchema.pm | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

pve-cluster:

Dominik Csapak (3):
  add CFS_IPC_GET_GUEST_CONFIG_PROPERTIES method
  Cluster: add get_guest_config_properties
  datacenter.cfg: add option for tag-style

 data/PVE/Cluster.pm          |  27 ++++++
 data/PVE/DataCenterConfig.pm |  37 ++++++++
 data/src/cfs-ipc-ops.h       |   2 +
 data/src/server.c            |  64 +++++++++++++
 data/src/status.c            | 177 ++++++++++++++++++++++++-----------
 data/src/status.h            |   3 +
 6 files changed, 254 insertions(+), 56 deletions(-)

proxmox-widget-Toolkit:

Dominik Csapak (3):
  add tag related helpers
  add class for 'admin' tags
  Toolkit: add override for Ext.dd.DragDropManager

 src/Toolkit.js       | 16 ++++++++
 src/Utils.js         | 94 ++++++++++++++++++++++++++++++++++++++++++++
 src/css/ext6-pmx.css | 49 +++++++++++++++++++++++
 3 files changed, 159 insertions(+)

qemu-server:

Dominik Csapak (1):
  api: update: check 'admin' tags privileges

 PVE/API2/Qemu.pm  | 56 ++++++++++++++++++++++++++++++++++++++++++++++-
 PVE/QemuServer.pm |  3 ++-
 2 files changed, 57 insertions(+), 2 deletions(-)

pve-container:

Dominik Csapak (1):
  check_ct_modify_config_perm: check 'admin' tags privileges

 src/PVE/LXC.pm        | 31 +++++++++++++++++++++++++++++++
 src/PVE/LXC/Config.pm |  3 ++-
 2 files changed, 33 insertions(+), 1 deletion(-)

pve-manager:

Dominik Csapak (14):
  api: /cluster/resources: add tags to returned properties
  api: /version: add 'tag-style'
  ui: parse and save tag color overrides from /version
  ui: tree/ResourceTree: collect tags on update
  ui: add form/TagColorGrid
  ui: dc/OptionView: add editors for tag settings
  ui: add form/Tag
  ui: add form/TagEdit.js
  ui: {lxc,qemu}/Config: show Tags and make them editable
  ui: tree/ResourceTree: show Tags in tree
  ui: form/GlobalSearchField: display tags and allow to search for them
  ui: form/Tag: add 'admin-tag' class to admin tags
  ui: ResourceGrid: render tags
  ui: form/Tag(Edit): add drag & drop when editing tags

 PVE/API2.pm                            |   7 +-
 PVE/API2/Cluster.pm                    |   9 +-
 www/css/ext6-pve.css                   |   5 +
 www/manager6/Makefile                  |   3 +
 www/manager6/Utils.js                  |  69 +++++
 www/manager6/Workspace.js              |  13 +
 www/manager6/data/ResourceStore.js     |   9 +
 www/manager6/dc/OptionView.js          |  84 ++++++
 www/manager6/form/GlobalSearchField.js |  20 +-
 www/manager6/form/Tag.js               | 294 ++++++++++++++++++++
 www/manager6/form/TagColorGrid.js      | 357 +++++++++++++++++++++++++
 www/manager6/form/TagEdit.js           | 245 +++++++++++++++++
 www/manager6/grid/ResourceGrid.js      |   1 +
 www/manager6/lxc/Config.js             |  36 ++-
 www/manager6/qemu/Config.js            |  35 ++-
 www/manager6/tree/ResourceTree.js      |  20 +-
 16 files changed, 1190 insertions(+), 17 deletions(-)
 create mode 100644 www/manager6/form/Tag.js
 create mode 100644 www/manager6/form/TagColorGrid.js
 create mode 100644 www/manager6/form/TagEdit.js

-- 
2.30.2





More information about the pve-devel mailing list