[pve-devel] applied-series: [PATCH manager/docs v3] handle missed jobs better

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 17 17:34:41 CEST 2022


Am 13/06/2022 um 15:24 schrieb Dominik Csapak:
> by adding a config option 'repeat-missed' for jobs that repeats the jobs
> on pvescheduler start. new default is 0, which is reverse to current
> behaviour (but the more expected one)
> 
> also always skips "missed" jobs when changing from disabled to enabled,
> since that is not expected
> 
> changes from v2:
> * indendation/whitespaces fixes
> * line length/wording fixes
> * renamed updated_job_schedule to update_last_runtime

picking up R-b's (much thanks for doing that!) could be also seen as somewhat
noteworthy change IMO, but I could find it out by actually checking the patches
rather quickly, so def. no biggie (just mentioning it early now that we work more
and more with patch series that got mainly reviewed by someone else than the one
pushing it out).

> 
> changes from v1:
> * rename 'skip-missed' to 'repeat-missed' and reverse the default
> * always update timestamp on disabled -> enabled
> * put the checkbox in advanced items
> 
> pve-manager:
> 
> Dominik Csapak (3):
>   fix #4026: add 'repeat-missed' option for jobs
>   fix #4053: don't run vzdump jobs when they change from
>     disabled->enabled
>   ui: dc/Backup: add 'repeat-missed' checkbox
> 
>  PVE/API2/Backup.pm          | 37 ++++++++++++++++++++++++++++++++-----
>  PVE/Jobs.pm                 |  8 +++++++-
>  PVE/Jobs/Plugin.pm          |  7 +++++++
>  PVE/Jobs/VZDump.pm          |  1 +
>  PVE/Service/pvescheduler.pm |  6 +++++-
>  www/manager6/dc/Backup.js   | 13 ++++++++++++-
>  6 files changed, 64 insertions(+), 8 deletions(-)
> 
> pve-docs:
> 
> Dominik Csapak (1):
>   vzdump: add section about 'repeat-missed'
> 
>  vzdump.adoc | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

applied, thanks!




More information about the pve-devel mailing list