[pve-devel] applied series: [PATCH storage v4 1/4] fix #3972: Remove the .notes file when a backup is deleted

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Jun 15 10:52:10 CEST 2022


applied series and removed the empty lines between the S-o-b and R-b
lines.

On Tue, Jun 14, 2022 at 11:00:10AM +0200, Daniel Tschlatscher wrote:
> When a VM or Container backup was deleted, the .notes file was not
> removed, therefore, over time the dump folder would get polluted with
> notes for backups that no longer existed. As backup names contain a
> timestamp and as the notes cannot be reused because of this, I think
> it is safe to just delete them just like we do with the .log file.
> 
> Furthermore, I sourced the deletion of the log and notes file into a
> new function called "archive_auxiliaries_remove". Additionally, the
> archive_info object now returns one more field containing the name of
> the notes file. The test cases have to be adapted to expect this new
> value as the package will not compile otherwise.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>
> 
> Reviewed-by: Fabian Ebner <f.ebner at proxmox.com>






More information about the pve-devel mailing list