[pve-devel] [PATCH v3 container] fix: #3927: Error codes when starting/stopping

Fabian Ebner f.ebner at proxmox.com
Tue Jun 14 12:46:52 CEST 2022


Am 21.03.22 um 10:33 schrieb Daniel Tschlatscher:
>  containers Stopping and starting a container that is already in the desired
>  state will not return an error value on the CLI anymore. The same as VMs do,
>  when they are stopped but not running.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher at proxmox.com>

This also applies to the second patch: I'd feel more comfortable keeping
the error exit codes for the start commands. There might be users
already relying upon this behavior. If start succeeds, we know we have a
freshly started instance. We actually rely on it a bit ourselves, for
migration to detect a bogus instance already running on the target node.

For the stop command, it's not as relevant IMHO, and I'm fine with
either way, but we might want to wait until the next major release as it
can be seen as a breaking API change too.




More information about the pve-devel mailing list