[pve-devel] [PATCH-SERIES v2 manager/guest-common] replication: improve removal of stale snapshots/volumes

Fabian Ebner f.ebner at proxmox.com
Mon Jun 13 12:29:53 CEST 2022


In certain scenarios, see manager 2/2 and guest-common 3/4, replicated
volumes could end up orphaned. This series attempts to fix those, as
well as making removal of stale replication snaphsots a bit more
robust. Also includes some slight documentation improvements regarding
prepare().

v1 can be found here (but there was no discussion):
https://lists.proxmox.com/pipermail/pve-devel/2020-October/045388.html

Changes from v1:
    * Adapt to changed behavior of prepare(), so we still only catch
      volumes that had replication snapshots belonging to the job.
    * Drop simplification that would only rely on replication state
      to get storages for full removal.
    * Add safe-guard to only remove other replication snaphsots if the
      last_sync snapshot is present.


manager:

Fabian Ebner (2):
  pvesr: rename last_snapshots to local_snapshots
  pvesr: prepare local job: remove stale replicated volumes immediately

 PVE/CLI/pvesr.pm | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)


guest-common:

Fabian Ebner (4):
  replication: prepare: adapt/expand function comment
  replication: rename last_snapshots to local_snapshots
  replication: also consider storages from replication state upon
    removal
  replication: prepare: safeguard against removal if expected snapshot
    is missing

 src/PVE/Replication.pm | 34 ++++++++++++++++++++--------------
 1 file changed, 20 insertions(+), 14 deletions(-)

-- 
2.30.2





More information about the pve-devel mailing list