[pve-devel] [PATCH v2 manager] fix #3961: pveam: error on 'list' if storage doesn't exist

Oguz Bektas o.bektas at proxmox.com
Mon Jun 13 12:13:16 CEST 2022


storage_check_enabled() already dies with an appropriate error message
so we don't have to handle it here

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---
v1->v2:
* use storage_check_enabled() to address fabi's review


 PVE/CLI/pveam.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/CLI/pveam.pm b/PVE/CLI/pveam.pm
index 67a912bd..3db2a3c8 100644
--- a/PVE/CLI/pveam.pm
+++ b/PVE/CLI/pveam.pm
@@ -122,6 +122,8 @@ __PACKAGE__->register_method ({
 
 	my $cfg = PVE::Storage::config();
 
+	PVE::Storage::storage_check_enabled($cfg, $storeid);
+
 	die "Storage does not support templates!\n" if !$cfg->{ids}->{$storeid}->{content}->{vztmpl};
 
 	my $vollist = PVE::Storage::volume_list($cfg, $storeid, undef, 'vztmpl');
-- 
2.30.2





More information about the pve-devel mailing list