[pve-devel] [PATCH v4 manager] HDEdit: check iothread by default and move it from advanced section

Fabian Ebner f.ebner at proxmox.com
Fri Jun 10 11:20:25 CEST 2022


Am 27.05.22 um 13:48 schrieb Matthias Heiserer:
> Existing disks are not changed by this.
> Especially in benchmarks, iothreads significantly improve IO performance.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>

Reviewed-by: Fabian Ebner <f.ebner at proxmox.com>

> ---
> 
> Changes from v3:
> * remove automatically switching to/from SCSI single when iothread is (un)checked
> * iothread will be initially set on
> * changing the controller to something other than SCSI single and then back to
>   SCSI single will enable iothread for all SCSI disks.

I like this version much more. We could still add validation/warning to
the checkbox, but IMHO not a big deal with the new default and improved
warning upon VM start. Just wondering if we should enable iothread by
default for virtio disks too, or is the performance improvement not as
relevant there?




More information about the pve-devel mailing list