[pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning pve-manager

Daniel Bowder daniel at bowdernet.com
Thu Jun 9 17:43:21 CEST 2022


> Is a string the best way of entering the CPUs in the GUI? Maybe a
> dropdown where you can (un)select the cores?

It would be a nice gui element to have a list of CPU cores with the ability
to select individual ones. Such a feature would require the Options.js to
know how many CPU cores the system had to dynamically generate the
list I do not know how one would get that information to Options.js, but it
certainly seems feasible. The cpuset list must be created eventually so
that the cpuset can be used by taskset, so the underlying data structure
remains this string.

I do not yet have the required knowledge to add a dynamically generated
list of CPU cores in the Options.js file. I do have the required knowledge
to add this string formatted list.

I would argue that having the feature in the GUI as a string is acceptable
as a version 1 implementation. The string format does not lock us into
anything and the gui can be upgraded to a fancy list in the future with no
hindrances. The cpuset format in $vmid.conf is the way that this variable
should be stored, so on the backend, there's nothing to change.


More information about the pve-devel mailing list