[pve-devel] applied-series: [RFC/PATCH v2 qemu 1/3] PVE-Backup: create jobs: correctly cancel in error scenario

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Jun 8 14:04:23 CEST 2022


On Wed, May 25, 2022 at 01:59:37PM +0200, Fabian Ebner wrote:
> The first call to job_cancel_sync() will cancel and free all jobs in
> the transaction, so ensure that it's called only once and get rid of
> the job_unref() that would operate on freed memory.
> 
> It's also necessary to NULL backup_state.pbs in the error scenario,
> because a subsequent backup_cancel QMP call (as happens in PVE when
> the backup QMP command fails) would try to call proxmox_backup_abort()
> and run into a segfault.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>

Series LGTM, applied, thanks




More information about the pve-devel mailing list