[pve-devel] applied-series: [PATCH guest-common v2 1/2] ReplicationState: purge state from non local vms
t.lamprecht at proxmox.com
Wed Jun 8 08:49:12 CEST 2022
Am 03/06/2022 um 09:16 schrieb Dominik Csapak:
> when running replication, we don't want to keep replication states for
> non-local vms. Normally this would not be a problem, since on migration,
> we transfer the states anyway, but when the ha-manager steals a vm, it
> cannot do that. In that case, having an old state lying around is
> harmful, since the code does not expect the state to be out-of-sync
> with the actual snapshots on disk.
> One such problem is the following:
> Replicate vm 100 from node A to node B and C, and activate HA. When node
> A dies, it will be relocated to e.g. node B and start replicate from
> there. If node B now had an old state lying around for it's sync to node
> C, it might delete the common base snapshots of B and C and cannot sync
> Deleting the state for all non local guests fixes that issue, since it
> always starts fresh, and the potentially existing old state cannot be
> valid anyway since we just relocated the vm here (from a dead node).
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> Reviewed-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> src/PVE/ReplicationState.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied, with Fabi's R-b, thanks!
More information about the pve-devel