[pve-devel] [RFC PATCH guest-common 1/2] ReplicationState: purge state from non local vms

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 3 08:45:25 CEST 2022


Am 02/06/2022 um 16:33 schrieb Fabian Grünbichler:
>> Replicate vm 100 from node A to node B and C, and activate HA. When node
>> A dies, it will be relocated to e.g. node B and start replicate from
>> there. If node B now had an old state lying around for it's sync to node
>> C, it might delete the common base snapshots of B and C and cannot sync
>> again.
>>
>> Deleting the state for all non local guests fixes that issue, since it
>> always starts fresh, and the potentially existing old state cannot be
>> valid anyway since we just relocated the vm here (from a dead node).
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> the logic seems sound, the state *is* invalid/outdated once the guest 
> has been stolen..
> 
> Reviewed-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> 

Thanks! @Dominik, can you please send a v2 with Fabian's R-b and the nit from
patch 1/2 addressed? thanks!




More information about the pve-devel mailing list