[pve-devel] applied: [PATCH container] fix #4164: use DHCP=yes instead of DHCP=both in systemd-networkd config

[Wolfgang Bumiller]

On Tue, Jul 19, 2022 at 01:54:50PM +0200, Oguz Bektas wrote:
> On Tue, Jul 19, 2022 at 01:52:37PM +0200, Fabian Grünbichler wrote:
> > On July 19, 2022 1:24 pm, Oguz Bektas wrote:
> > > "both" option is deprecated, this gets rid of the warning in the journal
> > > 
> > > Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> > 
> > some notion which templates you tested this with, when the deprecation 
> > happened in systemd, whether we need a fallback to 'both' for older 
> > versions, etc.pp. would be nice to have..
> > 
> > AFAICT the deprecation was in systemd v219, so should probably be okay 
> > to switch unconditionally..
> 
> yes, all our current templates are using the newer systemd versions, so
> no need for a fallback IMO.
> 
> i tested it with:
> * arch
> * fedora 35 and 36
> * ubuntu 20 and 22
> templates, it got rid of the warning in all of them.

Introduced in 2015 is old enough. Anybody using a container which
actually uses systemd-networkd *and* is that old will just have to
enable dhcp manually...

Applied.