[pve-devel] [PATCH V2 manager 1/3] fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes

Fabian Ebner f.ebner at proxmox.com
Tue Jul 19 08:50:57 CEST 2022


Am 18.07.22 um 16:33 schrieb Stefan Hrdlicka:
> Servus Fabian,
> 
> wenn ich die automatische Node Einschränkung weg nehme. Dann müsste ich
> vermutlich etwas im Perl code anpassen, da ich sonst einen Fehler
> bekomme wenn ich versuche neue Storages auf anderen Nodes hinzufügen. Da
> er dann überprüft ob das Storage auch verfügbar ist/existiert. Das ist
> z.B. bei ZFS oder LVMThin ist der Fall.
> 
> Was sagst du denn dazu?
> 

Please always post such discussions about patches/development to the
developer list, so others can see it too ;) Also, please use
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

For non-German speakers: Stefan is concerned that users will run into
errors when the node is not automatically restricted.

Well, it actually *is* an error if the storage is configured for all
nodes and not available on the current (i.e. from where it's added) node.

But you do have a point of course, because why would a user even change
the node to scan, if the storage is already available on the current node.

I'd still rather not change the default restriction behavior (see
below). Maybe we should just auto-restrict if the user actively changed
the node to scan?

> grüße Stefan
> 
> 
> On 6/28/22 12:33, Fabian Ebner wrote:
>> Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
>>> This adds a dropdown box for iSCSI, LVM, LVMThin & ZFS storage
>>> options where a
>>> cluster node needs to be chosen. As default the current node is
>>> selected. It restricts the the storage to be only availabe on the
>>> selected node.
>>
>> I don't think we should change the default restriction, especially for
>> iSCSI and (shared) LVM, but also for local ones, as in many cases,
>> cluster nodes will be set-up with similar storage and the new default
>> might trip up some people.
>>
>>>




More information about the pve-devel mailing list