[pve-devel] [PATCH proxmox-backup/common/storage/wt v2] add tar.zst download in pve

Dominik Csapak d.csapak at proxmox.com
Wed Jul 13 11:43:10 CEST 2022

like we have the tar.zst download button for pbs itself, add it for
pve for both vms and container file-restore

pve-storage depends on pve-common, which depends on proxmox-backup,
(we must add the recently bumped proxmox-compression as a
dependency; also for the restore-daemon)

changes from v1:
* split format into 'format' and 'zstd'
* also use those parameters for file-restore
  (keep 'tar' for the pve api for gui compatibility)
* use an '#[api]'  enum for the format type

i kept the 'tar' for the pve api, since that way it makes it easily
compatible with the current gui. I'd understand that we maybe also
here want to have the 'format'/'zst' options and simply pass them

in that case, we "have" to adapt the pbs-api too since there we already
have the 'tar' parameter, or we have  to have two codepaths for the gui
depending which api we want to use.

No problem for a v3 either way, there just was not really an feedback
on that in my previous versions.


Dominik Csapak (4):
  file-restore: update dependencies
  pbs-api-types: add FileRestoreFormat type
  restore-daemon: add 'format' and 'zstd' parameters to the 'extract'
  file-restore: add 'format' and 'zstd' parameters to 'extract' command

 pbs-api-types/src/file_restore.rs             |  15 +++
 proxmox-file-restore/Cargo.toml               |   4 +-
 proxmox-file-restore/src/block_driver.rs      |  12 ++-
 proxmox-file-restore/src/block_driver_qemu.rs |  15 +--
 proxmox-file-restore/src/main.rs              | 100 +++++++++++++++---
 .../src/proxmox_restore_daemon/api.rs         |  46 ++++++--
 6 files changed, 157 insertions(+), 35 deletions(-)


Dominik Csapak (1):
  PBSClient: add 'tar' parameter to file_restore_extract

 src/PVE/PBSClient.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)


Dominik Csapak (1):
  api/filerestore: add 'tar' parameter to 'download' api

 PVE/API2/Storage/FileRestore.pm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)


Dominik Csapak (1):
  window/FileBrowser: enable tar button by default

 src/window/FileBrowser.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)


More information about the pve-devel mailing list