[pve-devel] [PATCH v2 http-server 2/2] AnyEvent: Fix #3990 - make small files uploadable

Matthias Heiserer m.heiserer at proxmox.com
Tue Jul 12 13:32:11 CEST 2022


On 06.07.2022 18:09, Daniel Tschlatscher wrote:
> All errors above return HTTP status 501 ("Not implemented") which I
> think is rather confusing, even if they include a descriptive error
> message.
> I'd wager that it would be better to differentiate between malformed
> multi-form data and internal server errors, and return 400 for incorrect
> user inputs. This makes it much easier for anyone (that is not a
> browser) to interface with this part of the API.
> 
> I am not quite sure how much precedence fixing the errors above should
> have, as even most API users will probably never encounter them.
> However, I feel like that at the very least the basic error message
> should be revised to no longer return 501 and to include a more
> descriptive error message than just "upload failed".
As we talked off list: The 501 error is what we currently return. I 
don't mind using more descriptive ones, but as it changes the API I'm 
not sure if this patch is the right place.
Thanks for testing!




More information about the pve-devel mailing list