[pve-devel] [PATCH v2 proxmox-perl-rs] move apt repositories module to common

Wolfgang Bumiller w.bumiller at proxmox.com
Fri Jul 8 11:15:55 CEST 2022


On Thu, Jul 07, 2022 at 12:38:42PM +0200, Fabian Ebner wrote:
> while introducing a 'product' parameter to the relevant functions and
> adding wrappers for backwards-compatibility.
> 
> Suggested-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v1:
>     * Add wrappers, so we can defer the Breaks to later.
>     * Drop unnecessary changes in Proxmox/Lib/Common.pm
> 
> libproxmox-perl-rs needs a depends/breaks+replaces with both
> libpve-rs-perl and libpmg-rs-perl, because it now includes the
> P{MG,VE}/APT/Repositories.pm file.

Oh I actually meant turning the rust side into wrappers, rather than
adding perl wrappers, that way it wouldn't move into the common package
and no depends/breaks would be required, unless I'm missing something?

(...)
> --- a/pve-rs/src/apt/repositories.rs
> +++ /dev/null

iow. keep this file/module around


> @@ -1,162 +0,0 @@
(...)
> -#[perlmod::package(name = "PVE::RS::APT::Repositories", lib = "pve_rs")]
> -mod export {
> -    #[export]
> -    pub fn repositories() -> Result<RepositoriesResult, Error> {

but call out to the common code here in the `#[export]`s.

because once we remove the wrappers we'll be adding more break entries
still




More information about the pve-devel mailing list