[pve-devel] [PATCH v2 manager] ui: restore: improve warning for restoring container with same ID

Fabian Ebner f.ebner at proxmox.com
Tue Jul 5 10:52:39 CEST 2022


It's not clear to users that the "VM data" includes mount point
volumes including those that are not marked for backup. This is
different from VM restore, where volumes attached at drives not
present in the backup will be kept around as unused volumes.

Several (supposedly newer) users got tripped up by this over the
years, the latest report being [0]. The long term plan is to make the
restore dialog more flexible to be able to select actions for disks
individually, but that will take a bit of time. In the mean time, make
the warning more explicit.

[0]: https://forum.proxmox.com/threads/111760/#post-482045

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---

Changes from v1:
    * Text for gettext() is required to be on the same line.

 www/manager6/window/Restore.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
index 6738d26f..f3b51c81 100644
--- a/www/manager6/window/Restore.js
+++ b/www/manager6/window/Restore.js
@@ -92,7 +92,13 @@ Ext.define('PVE.window.Restore', {
 	    };
 
 	    if (view.vmid) {
-		confirmMsg += '. ' + gettext('This will permanently erase current VM data.');
+		confirmMsg += `. ${Ext.String.format(
+		    gettext('This will permanently erase current {0} data.'),
+		    view.vmtype === 'lxc' ? 'CT' : 'VM',
+		)}`;
+		if (view.vmtype === 'lxc') {
+		    confirmMsg += ` ${gettext('Mount point volumes are also erased.')}`;
+		}
 		Ext.Msg.confirm(gettext('Confirm'), confirmMsg, function(btn) {
 		    if (btn === 'yes') {
 			executeRestore();
-- 
2.30.2





More information about the pve-devel mailing list