[pve-devel] applied: Re: [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 5 08:43:23 CEST 2022


On 04/07/2022 17:45, Stefan Sterz wrote:
> when installing non-quincy versions, 'ceph-volume' is not contained in
> the respective repositories and, thus, the install process would fail.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> tested this by installing octopus, pacific and quincy. same issues as
> before.
> 
>  PVE/CLI/pveceph.pm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
>

applied, thanks! reworded the commit subject a bit and in a followup commit
also the comment to make it clearer when we can drop support for that.

FWIW, the thought on forward compatibility is a good one, but often we either
translate the code names to versions so that we can do a easier to understand,
and often also a bit more robust

`$ver_map->{$cephver} >= $ver_map->{quincy}`

But I don't expect much change here until we can just remove it with 8.0, where
we probably don't support new pacific installations anyway, so your variant is
just fine here.




More information about the pve-devel mailing list