[pve-devel] applied-series: [PATCH v2 manager 1/3] ui: rbd: cephfs: add keyring/secret field for external clusters

Fabian Ebner f.ebner at proxmox.com
Fri Jan 28 12:23:01 CET 2022


Am 26.01.22 um 11:18 schrieb Aaron Lauterer:
> Manual switching of xtype because binding 'hidden' does not work with
> pmxDisplayEditField.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> changes: added spaces in front of `?` operator that were missed.
> 
> 
> From previous iteration for this patch:
> 
> Reviewed-by: Fabian Ebner <f.ebner at proxmox.com>
> Tested-by: Fabian Ebner <f.ebner at proxmox.com>
> 
>  www/manager6/storage/CephFSEdit.js | 39 ++++++++++++++++++++----------
>  www/manager6/storage/RBDEdit.js    | 11 +++++++++
>  2 files changed, 37 insertions(+), 13 deletions(-)
>

thanks! Added two small followups after a brief discussion with Thomas,
namely using gettext('Secret Key') for the field label for CephFS and
making the "is done automatically for local cluster" more obvious in the
docs. Also added the missing f in the second commit title again ;)






More information about the pve-devel mailing list