[pve-devel] [PATCH manager v2] fix #3815: influxdb vmname should be string

Markus Frank m.frank at proxmox.com
Thu Jan 27 13:52:55 CET 2022


InfluxDB interprets the vmname 66601 as a number and the vmname vm42 as a String.
This leads to problematic metrics, that will be dropped by influxdb.
Whichever comes first decides how the "schema" is defined.

To change that I added a $quoted hashmap to quote a value.
In this case the value of name.

nodename and host are tags in InfluxDB so the only value they are able
to contain are strings:
https://docs.influxdata.com/influxdb/v2.1/reference/syntax/line-protocol/

Signed-off-by: Markus Frank <m.frank at proxmox.com>
---
 PVE/Status/InfluxDB.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
index def7e2fd..d63e18ac 100644
--- a/PVE/Status/InfluxDB.pm
+++ b/PVE/Status/InfluxDB.pm
@@ -276,6 +276,7 @@ sub test_connection {
 sub build_influxdb_payload {
     my ($class, $txn, $data, $ctime, $tags, $excluded, $measurement, $instance) = @_;
 
+    my $quoted = { name => 1 };
     my @values = ();
 
     foreach my $key (sort keys %$data) {
@@ -283,6 +284,10 @@ sub build_influxdb_payload {
 	my $value = $data->{$key};
 	next if !defined($value);
 
+	if (defined($quoted) && $quoted->{$key}) {
+	    $value =~ s/\"/\\\"/g;
+	    $value = "\"$value\"";
+	}
 	if (!ref($value) && $value ne '') {
 	    # value is scalar
 
-- 
2.30.2





More information about the pve-devel mailing list