[pve-devel] applied: [PATCH v2 manager 1/2] vzdump: example hook script: avoid undef warnings

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon Jan 17 16:32:09 CET 2022


On January 17, 2022 12:35 pm, Fabian Ebner wrote:
> Some environment variables are undef in certain scenarios.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> New in v2.
> 
>  vzdump-hook-script.pl | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/vzdump-hook-script.pl b/vzdump-hook-script.pl
> index 1be440b3..60edbc04 100755
> --- a/vzdump-hook-script.pl
> +++ b/vzdump-hook-script.pl
> @@ -15,11 +15,16 @@ if ($phase eq 'job-start' ||
>      $phase eq 'job-end'  ||
>      $phase eq 'job-abort') {
>  
> +    # undef for Proxmox Backup Server storages
>      my $dumpdir = $ENV{DUMPDIR};
>  
> +    # undef when --dumpdir is used directly
>      my $storeid = $ENV{STOREID};
>  
> -    print "HOOK-ENV: dumpdir=$dumpdir;storeid=$storeid\n";
> +    print "HOOK-ENV: ";
> +    print "dumpdir=$dumpdir;" if defined($dumpdir);
> +    print "storeid=$storeid;" if defined($storeid);
> +    print "\n";
>  
>      # do what you want
>  
> @@ -37,8 +42,10 @@ if ($phase eq 'job-start' ||
>  
>      my $vmtype = $ENV{VMTYPE}; # lxc/qemu
>  
> +    # undef for Proxmox Backup Server storages
>      my $dumpdir = $ENV{DUMPDIR};
>  
> +    # undef when --dumpdir is used directly
>      my $storeid = $ENV{STOREID};
>  
>      my $hostname = $ENV{HOSTNAME};
> @@ -47,9 +54,14 @@ if ($phase eq 'job-start' ||
>      my $target = $ENV{TARGET};
>  
>      # logfile is only available in phase 'log-end'
> +    # undef for Proxmox Backup Server storages
>      my $logfile = $ENV{LOGFILE};
>  
> -    print "HOOK-ENV: vmtype=$vmtype;dumpdir=$dumpdir;storeid=$storeid;hostname=$hostname;target=$target;logfile=$logfile\n";
> +    print "HOOK-ENV: ";
> +    for my $var (qw(vmtype dumpdir storeid hostname target logfile)) {
> +	print "$var=$ENV{uc($var)};" if defined($ENV{uc($var)});
> +    }
> +    print "\n";
>  
>      # example: copy resulting backup file to another host using scp
>      if ($phase eq 'backup-end') {
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 




More information about the pve-devel mailing list